D27502: Create ConfigView an unmanaged ConfigWidget

Benjamin Port noreply at phabricator.kde.org
Tue Feb 25 08:59:15 GMT 2020


bport added inline comments.

INLINE COMMENTS

> ervin wrote in settings.cpp:109
> This is an odd bit of logic, isn't it?

Yes indeed, but what we want is to save false if checked and true if not checked.
I moved the logic there in order to work with kconfigxt and with current implementation

> ervin wrote in configview.cpp:33
> I'm kind of surprised at this extra widget, can't we get rid of it?

I kept same widget logic as ConfigWidget. Ididn't want to change that to ensure we have the same baheviour

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200225/b6d4a651/attachment.html>


More information about the Kde-frameworks-devel mailing list