D27497: Fix code generation for entries with min/max

Benjamin Port noreply at phabricator.kde.org
Wed Feb 19 12:04:23 GMT 2020


bport added inline comments.

INLINE COMMENTS

> test_param_minmax.kcfg:17
> +</kcfg>
> \ No newline at end of file


Add a new line

> test_param_minmax.kcfgc:4
> +Mutators=true
> \ No newline at end of file


add a new line

> test_param_minmax_main.cpp:28
> +    return 0;
> +}

Missing new line at end of this file

> KConfigCommonStructs.h:185
> +QString newItemInner(
> +    const CfgEntry* entry,
> +    const QString &key,

Space before * not after

> kconfig_compiler.cpp:478
> +
> +QString newItem(const CfgEntry* entry, const QString &key, const QString& defaultValue,
> +                const KConfigParameters &cfg, const QString &param) {

Space before * not after

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200219/b16994ae/attachment.html>


More information about the Kde-frameworks-devel mailing list