D26918: Improve KNotification API docs

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Feb 17 14:44:29 GMT 2020


apol added inline comments.

INLINE COMMENTS

> jucato wrote in knotification.h:96
> Maybe we should keep this part that the icon name, especially that it has to be one that can be found by KIconLoader.

Since Qt5 KIconLoader is an implementation detail. Even our apps and frameworks use QIcon::fromTheme, I haven't looked at what KNotifications does but pretty sure it's using QIcon.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato
Cc: class, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200217/4f30c6e3/attachment.html>


More information about the Kde-frameworks-devel mailing list