D27433: Check activeModule before using it

Wolfgang Bauer noreply at phabricator.kde.org
Sun Feb 16 13:35:09 GMT 2020


wbauer created this revision.
wbauer added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
wbauer requested review of this revision.

REVISION SUMMARY
  `activeModule` can be a nullptr here, as this is outside/after the `if (activeModule)`.
  This causes kontact to crash when opening it's settings.
  
  BUG: 417396
  FIXED-IN: 5.68.0

TEST PLAN
  Start kontact and select "Configure Kontact" in ist "Settings" menu. It doesn't crash anymore.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D27433

AFFECTED FILES
  src/kcmultidialog.cpp

To: wbauer, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200216/8d0c2c47/attachment.html>


More information about the Kde-frameworks-devel mailing list