D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Feb 14 09:26:18 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> slavebase.cpp:1100
>          } else {
> -            qFatal("Fatal Error: Got cmd %d, while waiting for an answer!", cmd);
> +            qDebug("Error: Got cmd %d, while waiting for an answer!", cmd);
> +            return -1;

Should at least be `qWarning` imho

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

To: fifr, #frameworks, dfaure, meven
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200214/886da85a/attachment.html>


More information about the Kde-frameworks-devel mailing list