D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Noah Davis]

ndavis added a comment.


  In D27122#608443 <https://phabricator.kde.org/D27122#608443>, @niccolove wrote:
  
  > Using Background for panels would break the visual integration with dialogs, so I would avoid doing that.
  >
  > Regarding panel popups / dialogs; I'm already working on the toparea patch - https://phabricator.kde.org/D27189 - but I was thinking, the problem with using Background is the controls on top of it e.g. kickoff search. Since the transparency makes the background color not as gray, the only problem is when things are opaque (I remember we talked about this in the VDG chat). Now, *there is* a version of Breeze opaque in the breeze/opaque/ directory which is used when compositing is disabled. For that one, I did leave ColorScheme-Background, so the problem is not there when the actual opaque version is used. I think that people who want things to be 100% opaque will install a theme rather than manually editing the svg, so they would not have that problem as well. That isn't to say that I won't work on the top area, just that I would not make the this patch dependent on it.
  >
  > I also tried to tweak the intensity value to make the normal ColorScheme-Background fine, but I did not have any success. It seems like it's not a color which manages to work in this usecase, while ColorScheme-ViewBackground is okay.
  
  
  This is really about how this fits with our color scheme system, not so much about the aesthetics of transparency and blur. If you need different colors from normal to get this to look right, how will it look when you use other different colors? How does this look with color schemes besides Breeze and Breeze Dark (e.g., Arc Dark, Materia Dark)? If it only works properly with Breeze/Breeze Dark because ViewBackground is a lighter/darker color, this isn't going to work for all color schemes. You'll end up having to use a custom colors file anyway (as in Breeze Light/Dark desktop themes) to guarantee that everything will look right.
  
  Now that I've had the chance to try this patch, I can some issues. Even if you use a custom colors file, it seems this patch only looks right when there are no windows open, which doesn't seem realistic.
  
  Arc Dark: F8095615: Screenshot_20200210_114242.PNG <https://phabricator.kde.org/F8095615>
  
  Materia Dark: F8095604: Screenshot_20200210_113801.PNG <https://phabricator.kde.org/F8095604>
  
  Nordic-Darker: F8095606: Screenshot_20200210_113950.PNG <https://phabricator.kde.org/F8095606>
  
  Even Breeze Dark has trouble: F8095608: Screenshot_20200210_114056.PNG <https://phabricator.kde.org/F8095608>
  
  That's not to say the current situation is perfect, but the color difference isn't so stark (Breeze Dark): F8095617: Screenshot_20200210_114353.PNG <https://phabricator.kde.org/F8095617>
  
  Light themes don't really have this problem, but dark themes have a big problem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200210/7eec7ec6/attachment-0001.html>