D27288: [policy-gen] Fix the code to actually captured the correct capture group

Ahmad Samir noreply at phabricator.kde.org
Mon Feb 10 14:36:33 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This was a mistake in porting form QRegExp::capturedTexts() to QRegularExpression;
  capturedTexts(1) translates to QRegularExpressionMatch::captured(1), not 0.
  
  Thanks to brouilk for reporting it in https://phabricator.kde.org/D26118.
  
  TODO: add unit test to catch this

TEST PLAN
  make && ctest

REPOSITORY
  R283 KAuth

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200210/ce671f8e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list