D27157: [KConfigLoader] Code cleanup

Ahmad Samir noreply at phabricator.kde.org
Tue Feb 4 18:19:04 GMT 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Drop redundant args to startElement()/endEelement()
  - Use range-for
  - Drop ConfigLoaderHandler methods that weren't used anywhere AFAICS and ConfigLoaderHandler is private API

TEST PLAN
  make && ctest

REPOSITORY
  R237 KConfig

BRANCH
  l-configloader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27157

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: ahmadsamir, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200204/2d04236f/attachment.html>


More information about the Kde-frameworks-devel mailing list