D26600: Refactor fstab handling

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> system_filesystem_table_test.cpp:55
> +"devices /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0\n"
> +"freezer /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0\n"
> +"net_cls /sys/fs/cgroup/net_cls cgroup rw,nosuid,nodev,noexec,relatime,net_cls 0 0\n"

Perhaps add a squashfs mount "/dev/loop15 /snap/core/8268 squashfs ro,nodev,relatime 0 0"

> system_filesystem_table.cpp:61
> +{
> +    connect(&m_fstabWatcher, SIGNAL(tableChanged()), this, SLOT(fstabChanged()));
> +    connect(&m_mtabWatcher, SIGNAL(tableChanged()), this, SLOT(mtabChanged()));

Can't you use the new syntax ?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26600

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200204/1099269d/attachment.html>