D27017: [KColorUtils] Add hue(), chroma() and getHcyColor()

Matthew Woehlke noreply at phabricator.kde.org
Mon Feb 3 22:02:58 GMT 2020


mwoehlke added a comment.


  Indeed, we could have been having this conversation here instead of via e-mail ๐Ÿ˜‰. But, six of one...
  
  I believe `luma` and `chroma` are already guaranteed to return normalized values; it's just `hue` that you may want to normalize if you don't want to "surprise" users with its "natural" range of ยฏยนโ„โ‚† - โตโ„โ‚†.

INLINE COMMENTS

> kcolorspaces.cpp:161
> +{
> +    return KHCY(color).h;
> +}

So... per discussions, wrapping this in, well, `wrap` ๐Ÿ˜‰ might be reasonable.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27017

To: ndavis, #frameworks, dfaure
Cc: mwoehlke, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200203/aab41b38/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list