D7563: Add privilegeExecution field to file protocol description

Harald Sitter noreply at phabricator.kde.org
Mon Aug 10 12:53:32 BST 2020


sitter added a comment.


  In D7563#676151 <https://phabricator.kde.org/D7563#676151>, @cblack wrote:
  
  > In D7563#674682 <https://phabricator.kde.org/D7563#674682>, @sitter wrote:
  >
  > > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when certain timers happen to trigger. A trivial way to reproduce this is to try and duplicate a file in file:/
  >
  >
  > Can't reproduce, duplication works fine.
  
  
  It no longer deadlocks, it still doesn't work though. Now I get an empty file
  
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::copyAs: src= QUrl("file:///list") dest= QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotStart: CopyJob: stating the dest QUrl("file:///")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJob::slotResult: d->state= 1
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotResultStating: 
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotResultStating: dest is dir: true
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::statCurrentSrc: fast path! found info about QUrl("file:///list") in KCoreDirLister
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::addCopyInfoFromUDSEntry: fileName= "list" url= QUrl("file:///list")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::addCopyInfoFromUDSEntry: uSource= QUrl("file:///list") uDest(1)= QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::addCopyInfoFromUDSEntry:  uDest(2)= QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::addCopyInfoFromUDSEntry:   QUrl("file:///list") -> QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::sourceStated: Source is a file (or a symlink), or we are linking -> no recursive listing
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::statNextSrc: Setting m_dest to QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::statCurrentSrc: Stating finished. To copy: 39549 , available: 155277156352
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: 
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: preparing to copy QUrl("file:///list") 39549 155277156352
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: copying "/list copy"
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: Copying QUrl("file:///list") to QUrl("file:///list copy")
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotProcessedSize: 39549
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotProcessedSize: emit processedSize 39549
    kio_file(137793)/(kf5.kio.kio_file) FileProtocol::copy: Could not change permissions for "/list copy"
    kio_file(137793)/(kf5.kio.kio_file) FileProtocol::copy: Couldn't preserve group for "/list copy"
    kio_file(137793)/(kf5.kio.kio_file) FileProtocol::copy: Couldn't preserve access and modification time for "/list copy"
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJob::slotResult: d->state= 6
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::slotResultCopyingFiles: 0 files remaining
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: 
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJobPrivate::copyNextFile: copyNextFile finished
    dolphin(137764)/(kf5.kio.core.copyjob) KIO::CopyJob::emitResult: KDirNotify'ing FilesAdded QUrl("file:///")

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200810/bbf602bf/attachment-0001.htm>


More information about the Kde-frameworks-devel mailing list