D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

[Pino Toscano]

pino added a comment.


  In D29299#660466 <https://phabricator.kde.org/D29299#660466>, @kossebau wrote:
  
  > In D29299#660465 <https://phabricator.kde.org/D29299#660465>, @pino wrote:
  >
  > > Also, your patch basically includes D29136 <https://phabricator.kde.org/D29136> in the case of no DESTINATION parameter specified, hence my suggestion is:
  > >
  > > - edit D29136 <https://phabricator.kde.org/D29136> to do the fallback using the same logic introduced here: this way marble is already fixed with no other changes, and ki18n_install will work also with KDE_INSTALL_DIRS_NO_DEPRECATED (e.g. for release-service packages)
  > > - have this to add the DESTINATION parameter, so packages can opt-in to use it if they can/want
  >
  >
  > Not exactly sure what you mean? Do you want two separate commits/reviews, one per issue?
  
  
  Yes, and we have them already: D29136 <https://phabricator.kde.org/D29136> (to reopen) and this (which would need to rebased on the former).

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29299

To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200430/92a9c76a/attachment.html>