D29254: [RenameDialog] Add an arrow indicating direction from src to dest

Pino Toscano noreply at phabricator.kde.org
Thu Apr 30 14:32:17 BST 2020


pino added inline comments.

INLINE COMMENTS

> renamedialog.cpp:299
> +        // direction from src to dest
> +        const QPixmap pix = QIcon::fromTheme(QStringLiteral("go-next")).pixmap(d->m_srcPreview->height());
> +        srcToDestArrow->setPixmap(pix);

this is not right-to-left aware; please use the layout direction of the widget to use "go-next" or "go-previous"

REPOSITORY
  R241 KIO

BRANCH
  l-srt-to-dest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29254

To: ahmadsamir, #frameworks, dfaure, meven, ngraham
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200430/cd0c8fe6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list