D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

[Ahmad Samir]

ahmadsamir added a comment.


  Otherwise makes sense.

INLINE COMMENTS

> kprocessrunner.cpp:55
> +    if (!service->isValid()) {
> +        emitDelayedError(i18n("The desktop entry file\n%1\nis not valid.", service->entryPath()));
> +        return;

IMHO, the word "entry" here is confusing, the first thing that comes to mind is that an entry (i.e. a line) in the file is invalid.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29206

To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200427/11a05855/attachment.html>