D29221: [FakeCdrom] Add a new UnknownMediumType enumerator to MediumType

Ahmad Samir noreply at phabricator.kde.org
Mon Apr 27 10:34:53 BST 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, meven, bruns.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  As was discussed in https://phabricator.kde.org/D29138 and on IRC (with
  frinring and vkrause), add a new enumerator to MediumType with value 0
  to indicate no-op. Change one for-loop to use the new enumerator with
  QMap::value(key, defaultValue).

TEST PLAN
  make && ctest

REPOSITORY
  R245 Solid

BRANCH
  l-mediumtypes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29221

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakecdrom.cpp
  src/solid/devices/frontend/opticaldrive.h

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200427/bca7f3a9/attachment.html>


More information about the Kde-frameworks-devel mailing list