D29170: Detect executables without +x permission in $PATH to improve error message

Ahmad Samir noreply at phabricator.kde.org
Mon Apr 27 09:54:22 BST 2020


ahmadsamir accepted this revision.
ahmadsamir added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kprocessrunner.cpp:65
> +    const QStringList searchPaths = QString::fromLocal8Bit(qgetenv("PATH")).split(QDir::listSeparator(), skipEmptyParts);
> +    const QDir currentDir = QDir::current();
> +    for (const QString &searchPath : searchPaths) {

I guess there is no need to use QDir::current() any more.

REPOSITORY
  R241 KIO

BRANCH
  2020_04_findExecutable

REVISION DETAIL
  https://phabricator.kde.org/D29170

To: dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200427/196429c7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list