D29210: [NestedListHelper] Fix indentation of selection, add tests

Igor Poboiko noreply at phabricator.kde.org
Sun Apr 26 18:48:14 BST 2020


poboiko created this revision.
poboiko added reviewers: Frameworks, dfaure, mlaurent.
poboiko requested review of this revision.

REVISION SUMMARY
  When we try to increase / decrease an indentation level of a selection, just change
  indentation level of each block in the selection, and then make sure all styles
  are consistent via `reformatList`.
  
  This actually fixes indentation of selection: previously all blocks had the same indentation after this action.
  
  Add a unit test that covers as much weird selections & indentation cases as I could imagine.
  
  Slightly overlaps with D29208: [NestedListHelper] Improve indentation code <https://phabricator.kde.org/D29208>, so this one should be applied after that.

TEST PLAN
  `make && ctest`

BRANCH
  change-indent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29210

AFFECTED FILES
  autotests/krichtextedittest.cpp
  autotests/krichtextedittest.h
  src/widgets/krichtextedit.cpp
  src/widgets/nestedlisthelper.cpp
  src/widgets/nestedlisthelper_p.h

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/e0dffd86/attachment.html>


More information about the Kde-frameworks-devel mailing list