D29138: [Solid] Replace foreach (deprecated) with range/index for

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Apr 24 19:49:03 BST 2020


bruns added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in fakeopticaldisc.cpp:43
> Nice. :)
> 
> I think Solid::OpticalDisc::NoContent is more readable.

You forgot to remove the old lines.

Can also be applied to supportedMedia

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200424/63f188e3/attachment.html>


More information about the Kde-frameworks-devel mailing list