D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

David Faure noreply at phabricator.kde.org
Fri Apr 24 12:01:41 BST 2020


dfaure created this revision.
dfaure added reviewers: thiago, sitter.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  D27804 <https://phabricator.kde.org/D27804> broke compilation for me because I have the above flag set ;-)
  It showed rather some rather nasty QString -> QByteArray conversions in this code.

TEST PLAN
  Now it builds.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29149

AFFECTED FILES
  CMakeLists.txt
  smb/smburl.cpp

To: dfaure, thiago, sitter
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200424/a2ffadd6/attachment.html>


More information about the Kde-frameworks-devel mailing list