D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

Méven Car noreply at phabricator.kde.org
Fri Apr 24 06:31:39 BST 2020


meven added a comment.


  In D28590#654139 <https://phabricator.kde.org/D28590#654139>, @bruns wrote:
  
  > Do not create m_storageAccess in the constructor
  
  
  Hmm, you told me `the f (m_displayName.isEmpty()) block belongs here`, I don't see why instantiating `m_storageAccess` here is bad but mehh.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200424/c4e943b5/attachment.html>


More information about the Kde-frameworks-devel mailing list