D29061: [KCharSelect] Minor code optimisation

Ahmad Samir noreply at phabricator.kde.org
Wed Apr 22 14:55:23 BST 2020


ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kcharselectdata.cpp:870
> Shouldn't this be moved to inside the `if (match.hasMatch())` check?

Indeed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29061

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200422/125f75bf/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list