D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Apr 22 07:13:41 BST 2020


zzag added inline comments.

INLINE COMMENTS

> plasmawindowmanagement.cpp:242
>  
> +void PlasmaWindowManagement::Private::stackingOrderCallback(void *data, org_kde_plasma_window_management *interface, wl_array *ids) {
> +    auto wm = reinterpret_cast<PlasmaWindowManagement::Private*>(data);

The opening brace must be on a new line.

> plasmawindowmanagement.cpp:251
> +
> +void PlasmaWindowManagement::Private::setStackingOrder(QVector<quint32> ids)
> +{

Should be a const ref.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200422/a547cc4c/attachment.html>


More information about the Kde-frameworks-devel mailing list