D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

Ahmad Samir noreply at phabricator.kde.org
Sun Apr 19 16:25:53 BST 2020


ahmadsamir added a reviewer: broulik.
ahmadsamir added a comment.


  I had trouble finding what urlPatterns would look like, and only found trash:/ and run:/, also couldn't find any documentation about X-Plasma-DropUrlPatterns.
  
  Porting regex, especially with the pesky QRegExp::Wildcard, seeing what the pattern should look like always helps (and then adding a comment in the code with examples, that helps future changes, some docs say that the best regex-handling-code is one that has comments with examples of what the regex is supposed to match).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200419/b034947c/attachment.html>


More information about the Kde-frameworks-devel mailing list