D28953: [Extractor] Fix progress reporting

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Apr 18 19:46:47 BST 2020


bruns created this revision.
bruns added reviewers: Baloo, ngraham, mlaurent.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Commit 125b4db3230b <https://phabricator.kde.org/R293:125b4db3230b2f87119c5d52044b3ef1b2172518> ("Port endl to \n or std::cout/cerr as in qt5.15 endl
  is Qt:: namespaced") removed the implicit "endl" flush. As a result,
  the startedIndexing and finishedIndexing signals would be issued at the
  same time.
  
  This is especially bad when indexing large files, as both the KInfoCenter
  qml component and `balooctl monitor` would report the previous file (or
  no file at all, if only a single file is changed).

TEST PLAN
  start kinfocenter / balooctl monitor
  touch some huge PDF files

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28953

AFFECTED FILES
  src/file/extractor/app.cpp

To: bruns, #baloo, ngraham, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200418/1dd285b9/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list