D28862: [Extractor] Remove IdleStateMonitor wrapper class

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Apr 16 17:50:44 BST 2020


bruns added inline comments.

INLINE COMMENTS

> broulik wrote in app.cpp:63
> Coding style

Side note - both the Frameworks and the reference Qt coding style say nothing about lambdas.

If you read the `connect(...);` as a single statement, it should stay as is.

If you read the lambda as a function, the closing brace should go on a separate line.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200416/0f76aabd/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list