D24773: kio_trash: Add size, modification, access and create date for trash:/

David Faure noreply at phabricator.kde.org
Wed Apr 15 21:39:10 BST 2020


dfaure added a comment.


  TestTrash::renameDirInTrash makes the dir cache invalid (it still lists trashDirFromHome). I think because of the optimization that we don't always care about the size... but this had the side effect of keeping the cache uptodate.... I wonder if the test is too strict and an old cache isn't better than keeping it coherent at extra cost... I'll dig further.

INLINE COMMENTS

> trashimpl.cpp:411
>  
> -    const qulonglong pathSize = DiscSpaceUtil::sizeOfPath(origPath);
> -

This was done unconditionally...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200415/7b3faff8/attachment.html>


More information about the Kde-frameworks-devel mailing list