D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Apr 12 22:09:08 BST 2020


bruns added inline comments.

INLINE COMMENTS

> apol wrote in fstabmanager.cpp:122
> The debug seems wrong and probably unnecessary. I'd remove it.

What do you think is wrong with it?

And its the only debug output there is on this level, and always having to add debug statements in case of errors and then recompile it to get some traces is quite suboptimal. You can't ask a regular user to do it, and its silent by default.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28782

To: bruns, #frameworks, afiestas, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/92761dc8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list