D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Apr 12 14:59:39 BST 2020


bruns added inline comments.

INLINE COMMENTS

> meven wrote in fstabdevice.cpp:145
> I don't think that it is necessary : m_storageAccess already equals to `FstabHandling::mountPoints(m_device).first()`, looking at `FstabStorageAccess::FstabStorageAccess` and `FstabStorageAccess::onMtabChanged`. (That's why I wrote it like this in the first place).

I think it is. You always create a FstabStorageAccess instance now.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/eafcd5e3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list