D28765: KSettings::Dialog: add support for KPluginInfos without a KService

Carson Black noreply at phabricator.kde.org
Sun Apr 12 00:23:43 BST 2020


cblack added inline comments.

INLINE COMMENTS

> kcmoduleinfo.h:130
>       * @return a QExplicitlySharedDataPointer to KService created from the modules .desktop file
> +     * WARNING: this will be null if this KCModuleInfo was created from a KPluginInfo coming from KPluginMetaData
> +     * Prefer using pluginInfo() instead, which works for both kinds.

Use `@warning` instead of `WARNING:` for better markup

`WARNING:`
F8232033: image.png <https://phabricator.kde.org/F8232033>
`@warning:`
F8232034: image.png <https://phabricator.kde.org/F8232034>

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200411/2c3e2709/attachment.html>


More information about the Kde-frameworks-devel mailing list