D28274: [KFontChooser] Add a checkbox to toggle showing only monospaced fonts

Ahmad Samir noreply at phabricator.kde.org
Sat Apr 11 15:51:23 BST 2020


ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooser.cpp:393
> would `true` be more readable?
> 
> (same for the previous line, actually)

Indeed; however onlyFixedCheckbox->setChecked(usingFixed) doesn't need to be in that if block at all.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-monospace-checkbox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28274

To: ahmadsamir, #frameworks, dfaure, cfeck, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200411/c46bcd9c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list