D28669: make CopyJob non-recursive

Anthony Fieroni noreply at phabricator.kde.org
Thu Apr 9 12:02:47 BST 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:814
> Right. If this loop can really block the main thread for a substantial amount of time, then it should have a condition like "after 100 symlinks, schedule coming back here (e.g. QTimer singleshot) and `return;` for now".

So if `m_currentStatSrc` does not point to `m_srcList` end it should add timer event to queue returning back here in next queue iteration.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200409/16221fee/attachment.html>


More information about the Kde-frameworks-devel mailing list