D28528: UDSEntry: add constructor variant with std::initializer_list

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> udsentry.h:132
> +        const long long l;
> +        char s[sizeof(QString)];
> +    } m_u;

Why not simply QString*?

> udsentrybenchmark.cpp:141
> +            };
> +            m_smallEntries.append(entry);
> +        }

std::move(entry) if you want to skip the copying?

> udsentrybenchmark.cpp:145
> +
> +    Q_ASSERT(m_smallEntries.count() == numberOfSmallUDSEntries);
> +}

QCOMPARE()

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28528

To: kossebau, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/dd4d34b3/attachment.html>