D28592: [ApplicationLauncherJob] Guard against m_pids being empty

Ahmad Samir noreply at phabricator.kde.org
Sun Apr 5 14:21:06 BST 2020


ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  - 'sudo chmod a-x /usr/bin/gwenview'
  - Try opening a picure file from e.g. dolphin, you get an error message as expected, clicking OK makes dolphin crash because m_pids is empty and we hit an assert in QVector

REPOSITORY
  R241 KIO

BRANCH
  l-pids (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28592

AFFECTED FILES
  src/gui/applicationlauncherjob.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/894575d3/attachment.html>


More information about the Kde-frameworks-devel mailing list