D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

Ahmad Samir noreply at phabricator.kde.org
Sat Apr 4 18:34:35 BST 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> bruns wrote in jobtest.cpp:1510
> This should only apply to the `QVERIFY(device != otherDevice);`

Why? The goal is to test if the UDS_DEVICE_ID is unique for individual partitions, which won't work unless there are two separate partitions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200404/b4b8d730/attachment.html>


More information about the Kde-frameworks-devel mailing list