D28561: Remove border from format-border-set-* icons

[David Hurka]

davidhurka created this revision.
davidhurka added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REVISION SUMMARY
  These icons had a kind of border in ViewBackground color, which made them look a bit strange. I don’t know whether that was intended.
  But with swap_colors.sed (T12855 <https://phabricator.kde.org/T12855>), the generated dark version didn’t match the original dark version.
  So I removed the ViewBackground elements.
  
  - set-bottom and set-internal didn’t have this border, but they had elements outside the canvas (actually the border), which are removed now.
  - set-internal also had one element outside the canvas.
  - set-internal-vertical had the vertical edge outside the canvas. I fixed that.
  - set-none had all outer edges, so it was identical to set-all. I removed the edges, because it should probably have “none” edges.
  - set-all does not need fixing.
  
  Screenshots:
  Before: Light and dark versions have the ViewBackground border.
  
  In the autogenerated dark version, the border looks different.
  
  After: No border in light version and autogenerated dark version.
  
  Template file. Cyan is a proxy color for ColorScheme-Text with transparency 0.5.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

AFFECTED FILES
  icons-dark/actions/16/format-border-set-bottom.svg
  icons-dark/actions/16/format-border-set-diagonal-bl-tr.svg
  icons-dark/actions/16/format-border-set-diagonal-tl-br.svg
  icons-dark/actions/16/format-border-set-external.svg
  icons-dark/actions/16/format-border-set-internal-horizontal.svg
  icons-dark/actions/16/format-border-set-internal-vertical.svg
  icons-dark/actions/16/format-border-set-internal.svg
  icons-dark/actions/16/format-border-set-left.svg
  icons-dark/actions/16/format-border-set-none.svg
  icons-dark/actions/16/format-border-set-right.svg
  icons-dark/actions/16/format-border-set-top.svg
  icons/actions/16/format-border-set-bottom.svg
  icons/actions/16/format-border-set-diagonal-bl-tr.svg
  icons/actions/16/format-border-set-diagonal-tl-br.svg
  icons/actions/16/format-border-set-external.svg
  icons/actions/16/format-border-set-internal-horizontal.svg
  icons/actions/16/format-border-set-internal-vertical.svg
  icons/actions/16/format-border-set-internal.svg
  icons/actions/16/format-border-set-left.svg
  icons/actions/16/format-border-set-none.svg
  icons/actions/16/format-border-set-right.svg
  icons/actions/16/format-border-set-top.svg

To: davidhurka, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200404/cdad13bf/attachment.html>