D28555: File ioslave : use Better setting for sendfile syscall

Méven Car noreply at phabricator.kde.org
Sat Apr 4 14:37:27 BST 2020


meven added a comment.


  In D28555#641276 <https://phabricator.kde.org/D28555#641276>, @dfaure wrote:
  
  > any idea what buff_src.st_size < 0x7FFFFFFF was for?
  
  
  None, it does not makes sense to me, perhaps, we had an implementation limitation.
  
  In D28555#641277 <https://phabricator.kde.org/D28555#641277>, @broulik wrote:
  
  > >   reduce the overhead of processedSize dbus progress notification in each iteration since it is called less often, adding some more speed.
  >
  > From what I recall in copy job the processed size in emitted by a timer and not every time a chunk got processed
  
  
  You are right, it is emitted every 100ms in `SlaveBase::processedSize`, so this part was overzealot.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28555

To: meven, #frameworks, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200404/a34433f2/attachment.html>


More information about the Kde-frameworks-devel mailing list