D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Apr 3 15:09:38 BST 2020


kossebau added inline comments.

INLINE COMMENTS

> kio_smb_browse.cpp:239
> +        QString host = m_current_url.host();
> +        host = host.remove(host.size() - wsdSuffix.size(), wsdSuffix.size());
> +        const QString dnssd(host + ".local");

`QString::remove()` operates on the object itself, no need to assign back to host.

Besides, why not use `QString::chop(wsdSuffix.size())` ?

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-lazy-resolve

REVISION DETAIL
  https://phabricator.kde.org/D28513

To: sitter, ngraham, meven
Cc: kossebau, kde-frameworks-devel, kfm-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200403/f139d886/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list