D28476: Samba: Ensure to differenciate mounts sharing the same source

Méven Car noreply at phabricator.kde.org
Wed Apr 1 09:44:10 BST 2020


meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  `getmntent` for samba returns fsname of the form "//server/folder" (same as `mount`) 
  It is not sufficient to use in udi as device name as it does not differenciate mounts sharing the same source but having different mount points.
  
  BUG: 418906
  FIXED-IN: 5.69

TEST PLAN
  With a local cifs mount point:
  
  Before
  $ solid-hardware5 list | grep ourfiles
  udi = '/org/kde/fstab///meven-synapse/ourfiles'
  
  After
  $ solid-hardware5 list | grep ourfiles
  udi = '/org/kde/fstab///meven-synapse/ourfiles:/media/samba'

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28476

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200401/6eae150d/attachment.html>


More information about the Kde-frameworks-devel mailing list