D21483: Don't modify a temporary object

Aleix Pol Gonzalez noreply at phabricator.kde.org
Wed May 29 15:27:12 BST 2019


apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead copy the object, operate it and update it into the object.

TEST PLAN
  just used plasma shell and ran the tests. I'm not sure who uses this.
  Issue found with clazy.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21483

AFFECTED FILES
  src/plasma/CMakeLists.txt
  src/plasma/corona.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: apol, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190529/168b8d7f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list