D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added a comment.


  In D21459#471238 <https://phabricator.kde.org/D21459#471238>, @ngraham wrote:
  
  > Nice! What do you think about moving the `if (configGroup && itemView) {` into the new function and calling it something more conditional, like `writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code shared in a new function so that `KDirOperator::Private::iconSizeForViewType()` and `KDirOperator::Private::writeIconZoomSettings()` don't have to have so much duplicated code. They're both in the same scope so they have access to the same set of variables which should hopefully make it possible.
  
  
  I did your two nice suggestions. See `writeIconZoomSettingsIfNeeded` and `zoomSettingsForViewForView`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190529/52358666/attachment.html>