D21290: kio_ftp: improve error handling when copying to FTP fails

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun May 26 21:20:34 BST 2019


bruns added inline comments.

INLINE COMMENTS

> ftp.cpp:2358
>          if (cs == statusServerError) {
> -            sCopyFile = dest.toString();
> +            ftpCloseCommand();
> +            return;

ftpCopyPut calls iCopyFIle = QT_OPEN before calling ftpPut -> ftpSendCmd, so this leaks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21290

To: dfaure, bruns, apol, kossebau
Cc: kde-frameworks-devel, pino, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190526/74a2320e/attachment.html>


More information about the Kde-frameworks-devel mailing list