D21328: Add qml import for KItemModels

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12
> +
> +install(TARGETS itemmodelsplugin DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels)
> +install(FILES qmldir DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels)

With the macros of ECMAddQmlModule proposed in D20984 <https://phabricator.kde.org/D20984>, the explicit qmldir file could be removed and the install lines replaced by

  ecm_add_qmlmodule(itemmodelsqml
      IDENTIFIER org.kde.kitemmodels
      DESTINATION ${KDE_INSTALL_QMLDIR}
      PLUGIN itemmodelsplugin
      TYPEINFO plugins.qmltypes
      VERSION 1.0
  )

getting rid of all the duplicated identifiers and having the build-system instead know about them and propagate as needed from this single source.
It would also add support for a plugins.qmltypes file, thus providing metadata about the module for tools e.g. in cross-compilation scenarios.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D21328

To: davidedmundson
Cc: kossebau, vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190524/8d5e9db4/attachment.html>