D21354: Port to new connect syntax

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in delegate.cpp:46
> Nope, same issue I'm afraid.

GCC 8.3.1 gives me a helpful error message:

  ...samba/filepropertiesplugin/delegate.cpp: In lambda function:
  ...samba/filepropertiesplugin/delegate.cpp:48:58: error: passing ‘const UserPermissionDelegate’ as ‘this’ argument discards qualifiers [-fpermissive]
           [this, comboBox] (int) { emit commitData(comboBox); }

`this` is const as `createEditor(...)` is const. Apparently `connect` discards the constness of `this`.

But reading through https://doc.qt.io/qt-5/qtwidgets-itemviews-spinboxdelegate-example.html , it seems like the connect is not needed at all. The selected value is propagated via `setModelData`.

Can you test if it still works when you remove the whole `connect(...)` here?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190523/e0a8e88a/attachment.html>