D21354: Port to new connect syntax

Stefan BrĂ¼ns noreply at phabricator.kde.org
Wed May 22 23:30:40 BST 2019


bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:126
> +    connect(propertiesUi.sambaChk, &QCheckBox::toggled,
> +            this, &SambaUserSharePlugin::changed);
> +    connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged,

I think instead of emiting `KFilePropertiesPlugin::changed()` it would be better to call `setDirty()` in the slots.

See https://api.kde.org/frameworks/kio/html/classKPropertiesDialogPlugin.html#af25f4b84d915dcc005a203a637ad0511

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190522/13967ee1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list