D19677: WIP: Port UDisks to using DBus ObjectManager

[Aleix Pol Gonzalez]

apol added a comment.


  +1 do we know what's stopping this to move forward?
  
  At least the commit message needs addressing.

INLINE COMMENTS

> udisksmanager.h:41
>  
> +// interface -> [ {property: key}, {property: key}, ... ]
> +using PropertyMap = QMap<QString, QVariantMap>;

This comment looks wrong. If this was the case it would be QList<QVariantMap>

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190522/f32b1b3e/attachment.html>