D19367: SearchBar: Don't block GUI when enter incremental pattern

Christoph Cullmann noreply at phabricator.kde.org
Mon May 20 15:06:01 BST 2019


cullmann added a comment.


  Simple tests with an 12 million lines document (COPYING.LIB concated "a lot") show compare to the current approach usable behavior.
  You start to type some word not in the document, it won't free for 10 seconds, it will just search in the background like it should.
  I think the largest existing issue is IMHO the multi line stuff. Some more comments could help.
  
  Should the
  
  const int newChunkOverlap = pattern.count(QLatin1Char('\n'));
  ....
  
  actually disable it for multi line searches?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19367

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190520/5614d13a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list