D21249: Test current filter before setting a new one

Jan-Marek Glogowski noreply at phabricator.kde.org
Mon May 20 11:07:24 BST 2019


jglogowski updated this revision to Diff 58345.
jglogowski added a comment.


  - Merge test/kfilewidgettest_filter.cpp into autotests/kfilewidgettest.cpp
  - Swap QCOMPARE parameters to match actual + expected output on failure
  - Always test filter and file name
  
  Technically the '*' filter just makes sense as the last filter in the list and it's auto-selected if it's the first filter entry.
  That's out of scope here. Not sure if there should / could be a warning for a developer.
  
  Thanks for your patience.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21249?vs=58317&id=58345

REVISION DETAIL
  https://phabricator.kde.org/D21249

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kfilewidget.cpp

To: jglogowski, #frameworks, ngraham, dfaure
Cc: elvisangelaccio, ngraham, michaelweghorn, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190520/8e75e017/attachment.html>


More information about the Kde-frameworks-devel mailing list