D19608: DocumentPrivate: Make bracket handling smart

Dominik Haumann noreply at phabricator.kde.org
Sat May 18 21:20:37 BST 2019


dhaumann added a comment.


  I think this change introduces a regression: This code does not check for "view->config()->autoBrackets()", so it's *ALWAYS* active, which I do not want. Consider this:
  
    if (bla |) { ... }
  
  Now you type && foo(), the result is then:
  
    if (bla && foo() { ... }
  
  Notice the unbalanced closing ), which is due to this patch.
  
  Can we either revert this, or at least add config check?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19608

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: dhaumann, meven, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190518/1b2d97d5/attachment.html>


More information about the Kde-frameworks-devel mailing list