D21204: Ensure no trailing slash in mountpoint read from fstab file.

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue May 14 14:53:02 BST 2019


bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:168
>  
> +            // strips last slash
> +            if (mountpoint.at(mountpoint.length() -1) == '/') {

This is a litlle bit scarce ...

> apol wrote in fstabhandling.cpp:170
> you can call mountpoint.chop(2) for the same effect, which should be easier to read.

and why "2"?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190514/7f4b5d99/attachment.html>


More information about the Kde-frameworks-devel mailing list