D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

Nathaniel Graham noreply at phabricator.kde.org
Mon May 13 18:49:40 BST 2019


ngraham added a comment.


  In D20140#463834 <https://phabricator.kde.org/D20140#463834>, @ndavis wrote:
  
  > In D20140#458379 <https://phabricator.kde.org/D20140#458379>, @filipf wrote:
  >
  > > Which still leaves you with fixing the gaps when there's not thumbnail. I'd suggest to do:
  > >
  > > `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  > >
  > > and call it a day :P
  > >
  > > F6800961: image.png <https://phabricator.kde.org/F6800961>
  >
  >
  > Unfortuantely, that still leaves small white corners on the thumbnails that don't take up the entire area.
  >
  > F6819113: Screenshot_20190511_111410.png <https://phabricator.kde.org/F6819113>
  
  
  In practice, the thumbnail delegates are much smaller; is anyone gonna notice that (famous last words)?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190513/12e5840a/attachment.html>


More information about the Kde-frameworks-devel mailing list